Great Consensus Cleanup Revival

Chris_Stewart_5 · February 27, 2025, 5:23pm

Did you check all utxos one by one

and note, i excluded 0 value utxos. I also excluded any utxo that involves a checksig op (BIP66), and syntactically invalid Scripts (there is a lot of Scripts that have OP_IF with no OP_ENDIF!). I can rerun with different filters if you would like. Here is a link to the source code

github.com

Christewart/bitcoin-s-core/blob/dfcd59eddc7ac2d5c622136fa100e6a448d20021/app/scripts/src/main/scala/org/bitcoins/scripts/ScanBitcoind.scala#L225


      
                                  OP_CHECKSIGVERIFY,
                                  OP_CHECKMULTISIG,
                                  OP_CHECKMULTISIGVERIFY,
                                  OP_CHECKSIGADD,
                                  OP_RETURN)
          val find
              : Block => Future[Vector[(TransactionOutPoint, TransactionOutput)]] = {
            block =>
              val hasCheckSigOp = block.transactions.flatMap { tx =>
                val x: Vector[ScriptPubKey] = {
                  tx.outputs
                    .filter(_.value > CurrencyUnits.zero)
                    // bunch of txs that have an OP_IF but no corresponding OP_ENDIF
                    // making them consensus invalid
                    .filterNot(o =>
                      o.scriptPubKey.asm.contains(OP_IF) && !o.scriptPubKey.asm
                        .contains(OP_ENDIF))
                    .map(_.scriptPubKey)
                    .collect { case spk: NonStandardScriptPubKey =>
                      spk
                    }

In any case this statement is always true because you can just pad the scriptsig (even if that might be nonstandard).

This seems right to me but i haven’t tested this yet with the various interpreter flags (CLEANSTACK,PUSHONLY,MINIMALDATA etc).

Nice, did you bruteforce all possible valid script serializations from 0 to 3 bytes and checked no corresponding P2SH exist in the utxo set?

I’m pretty sure it was discussed around Greg’s segwit ephemeral anchors (renamed ephemeral dust along the road), as alluded to by garlonicon.

I’m getting caught up on this, if you have a link handy to the discussion it would be much appreciated.